Author Topic: Submitting patches?  (Read 1429 times)

EvilTrout

  • Guest
Submitting patches?
« on: Tue, Jan 5, 2010 »
Hi there,

I recently submitted a patch to Flixel via Github by forking and issuing a pull request. This is how I've done it before when contributing to Ruby projects, as I understand it's easy for the maintainer to review and accept the patch.

I noticed it hasn't been accepted yet. I just want to know if I should announce patches on the forum too? Or is a pull request enough for eventual review?

-ET

Adam Atomic

  • Founder
  • Key Contributor
  • *****
  • Posts: 852
  • Karma: +0/-0
  • new dad
    • View Profile
    • Adam Atomic
Re: Submitting patches?
« Reply #1 on: Tue, Jan 5, 2010 »
Sry, yea i have a couple of outstanding pull requests on the github.  That is totally the right way to do it, I just haven't had time to review the patches and decide if I want to incorporate them yet!

EvilTrout

  • Guest
Re: Submitting patches?
« Reply #2 on: Tue, Jan 5, 2010 »
Cool!

The patch I sent in was a simple bug fix so I imagine you'll accept it, but it is your call completely :P